Re: [PATCH v3] perf build: Specify that shellcheck should use the bash dialect.

From: Collin Funk
Date: Fri Jun 27 2025 - 23:49:39 EST


Collin Funk <collin.funk1@xxxxxxxxx> writes:

> Oops, I assumed that on a system without shellcheck NO_SHELLCHECK would
> be defined. Let me write another version.
>
> I think the 'command -v' change is best left for a separate patch(s).
> Since it is used in many other places, and maybe others will raise
> objections.

Okay, I sent V4 which makes sure SHELLCHECK is empty when the program
doesn't exist [1]. If it does exist, we then check the version. If it
does exit and is a supported version, we add the options, or else we set
it to empty.

Collin

[1] https://lore.kernel.org/linux-perf-users/63491dbc8439edf2e949d80e264b9d22332fea61.1751082075.git.collin.funk1@xxxxxxxxx/T/#u