Re: [net-next PATCH v15 05/12] dt-bindings: mfd: Document support for Airoha AN8855 Switch SoC

[Christian Marangi]

On Fri, Jun 27, 2025 at 04:48:21PM -0500, Rob Herring wrote:
> On Thu, Jun 26, 2025 at 11:23:04PM +0200, Christian Marangi wrote:
> > Document support for Airoha AN8855 Switch SoC. This SoC expose various
> > peripherals like an Ethernet Switch, a NVMEM provider and Ethernet PHYs.
> > 
> > It does also support i2c and timers but those are not currently
> > supported/used.
> > 
> > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> > ---
> >  .../bindings/mfd/airoha,an8855.yaml           | 175 ++++++++++++++++++
> >  1 file changed, 175 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/airoha,an8855.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/airoha,an8855.yaml b/Documentation/devicetree/bindings/mfd/airoha,an8855.yaml
> > new file mode 100644
> > index 000000000000..a683db4f41d1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/airoha,an8855.yaml
> > @@ -0,0 +1,175 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mfd/airoha,an8855.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Airoha AN8855 Switch SoC
> > +
> > +maintainers:
> > +  - Christian Marangi <ansuelsmth@xxxxxxxxx>
> > +
> > +description: >
> > +  Airoha AN8855 Switch is a SoC that expose various peripherals like an
> > +  Ethernet Switch, a NVMEM provider and Ethernet PHYs.
> > +
> > +  It does also support i2c and timers but those are not currently
> > +  supported/used.
> > +
> > +properties:
> > +  compatible:
> > +    const: airoha,an8855
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  reset-gpios: true
> > +
> > +  efuse:
> > +    type: object
> > +    $ref: /schemas/nvmem/airoha,an8855-efuse.yaml
> > +    description: EFUSE exposed by the Airoha AN8855 SoC
> > +
> > +  ethernet-switch:
> > +    type: object
> > +    $ref: /schemas/net/dsa/airoha,an8855-switch.yaml
> > +    description: Switch exposed by the Airoha AN8855 SoC
> > +
> > +  mdio:
> > +    type: object
> > +    $ref: /schemas/net/airoha,an8855-mdio.yaml
> > +    description: MDIO exposed by the Airoha AN8855 SoC
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - mdio
> > +  - ethernet-switch
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +
> > +    mdio {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        soc@1 {
> > +            compatible = "airoha,an8855";
> > +            reg = <1>;
> > +
> > +            reset-gpios = <&pio 39 0>;
> > +
> > +            efuse {
> > +                compatible = "airoha,an8855-efuse";
> > +
> > +                #nvmem-cell-cells = <0>;
> > +
> > +                nvmem-layout {
> > +                    compatible = "fixed-layout";
> > +                    #address-cells = <1>;
> > +                    #size-cells = <1>;
> > +
> > +                    shift_sel_port0_tx_a: shift-sel-port0-tx-a@c {
> > +                       reg = <0xc 0x4>;
> > +                    };
> > +
> > +                    shift_sel_port0_tx_b: shift-sel-port0-tx-b@10 {
> > +                        reg = <0x10 0x4>;
> > +                    };
> > +
> > +                    shift_sel_port0_tx_c: shift-sel-port0-tx-c@14 {
> > +                        reg = <0x14 0x4>;
> > +                    };
> > +
> > +                    shift_sel_port0_tx_d: shift-sel-port0-tx-d@18 {
> > +                       reg = <0x18 0x4>;
> > +                    };
> > +
> > +                    shift_sel_port1_tx_a: shift-sel-port1-tx-a@1c {
> > +                        reg = <0x1c 0x4>;
> > +                    };
> > +
> > +                    shift_sel_port1_tx_b: shift-sel-port1-tx-b@20 {
> > +                        reg = <0x20 0x4>;
> > +                    };
> > +
> > +                    shift_sel_port1_tx_c: shift-sel-port1-tx-c@24 {
> > +                       reg = <0x24 0x4>;
> > +                    };
> > +
> > +                    shift_sel_port1_tx_d: shift-sel-port1-tx-d@28 {
> > +                        reg = <0x28 0x4>;
> > +                    };
> > +                };
> > +            };
> > +
> > +            ethernet-switch {
> > +                compatible = "airoha,an8855-switch";
> > +
> > +                ports {
> 
> Same comment here.
> 
> Why do we need 2 examples of the same thing? Isn't this 1 complete 
> example here enough?
>

Do you prefer if I drop example from every other schema and keep only
this?

And with this change is it ok to keep the review tag?

-- 
	Ansuel