Re: [net-next, v2 04/10] bng_en: Add initial interaction with firmware

[Jakub Kicinski]

On Thu, 26 Jun 2025 14:08:13 +0000 Vikas Gupta wrote:
> @@ -128,10 +175,26 @@ static int bnge_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		goto err_devl_unreg;
>  	}
>  
> +	rc = bnge_init_hwrm_resources(bd);
> +	if (rc)
> +		goto err_bar_unmap;
> +
> +	rc = bnge_fw_register_dev(bd);
> +	if (rc) {
> +		dev_err(&pdev->dev, "Failed to register with firmware rc = %d\n", rc);
> +		goto err_hwrm_cleanup;
> +	}

you're adding this _after_ devlink has been registered
users can access the devlink ops before you finished init
-- 
pw-bot: cr