Re: [PATCH v2] dmaengine: idxd: Remove __packed from structures

[Vinod Koul]

On 27-06-25, 07:05, Andy Shevchenko wrote:
> Thu, Jun 26, 2025 at 03:48:11PM -0700, Vinod Koul kirjoitti:
> > 
> > On Fri, 04 Apr 2025 13:36:14 +0800, Yi Sun wrote:
> > > The __packed attribute introduces potential unaligned memory accesses
> > > and endianness portability issues. Instead of relying on compiler-specific
> > > packing, it's much better to explicitly fill structure gaps using padding
> > > fields, ensuring natural alignment.
> > > 
> > > Since all previously __packed structures already enforce proper alignment
> > > through manual padding, the __packed qualifiers are unnecessary and can be
> > > safely removed.
> 
> [...]
> 
> > Applied, thanks!
> 
> Please, don't or fix it ASAP. This patch is broken in the formal things,
> i.e. changelog entry must not disrupt SoB chain. I'm not sure if Stephen's
> scripts will catch this up on Linux Next integration, though.

Thanks for letting me know. My script didnt catch it, will check why.
I have fixed it up now

-- 
~Vinod