Re: [PATCH v11 14/14] unwind_user/x86: Enable compat mode frame pointer unwinding on x86

[Steven Rostedt]

On Thu, 26 Jun 2025 08:12:20 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> 
> 
> >   
> > > +/*
> > > + * If an architecture needs to initialize the state for a specific
> > > + * reason, for example, it may need to do something different
> > > + * in compat mode, it can define arch_unwind_user_init to a
> > > + * function that will perform this initialization.    
> > 
> > Please use 'func()' when referring to functions in comments.  
> 
> You mean to use "arch_unwind_user_init()"?
> 
> >   
> > > +/*
> > > + * If an architecture requires some more updates to the state between
> > > + * stack frames, it can define arch_unwind_user_next to a function
> > > + * that will update the state between reading stack frames during
> > > + * the user space stack walk.    
> > 
> > Ditto.  
> 
> And this to have arch_unwind_user_next()?

I went to go update these than realized that the are not functions. As the
comment says, "it can define arch_unwind_user_next", that means it has to be:

  #define arch_unwind_user_next arch_unwind_user_next

That's not a function. It's just setting a macro named arch_unwind_user_next to
be arch_unwind_user_next. I think adding "()" to the end of that will be
confusing. I could update it to say:

  ... it can define a macro named arch_unwind_user_next with the name of the
  function that will update ...

Would that work?

I may even change the x86 code to be:

#define arch_unwind_user_next x86_unwind_user_next

As the function name doesn't have to be the same as the macro.

-- Steve