Re: [PATCH v15 5/9] ref_tracker: allow pr_ostream() to print directly to a seq_file

[Krzysztof Karas]

Hi Jeff,

> On Mon, 2025-06-23 at 14:01 +0000, Krzysztof Karas wrote:
> > Hi Jeff,
> > 
> > [...]
> > > +static __maybe_unused int
> > > +ref_tracker_dir_seq_print(struct ref_tracker_dir *dir, struct seq_file *seq)
> > > +{
> > > +	struct ostream os = { .func = pr_ostream_seq,
> > > +			      .prefix = "",
> > This is also a "ref_tracker_*" function, so maybe use the same
> > prefix as in other functions? I mean .prefix = "ref_tracker:".
> > Unless, you have a reason for leaving it empty ;)
> > 
> 
> I have a reason to leave it empty.
> 
> That is the prefix for each line that gets printed by the pr_ostream()
> call. This one is for the lines that go to the debugfs files. I think
> it will be redundant to prepend every line in these files with
> "ref_tracker: ".

OK, this makes sense.
Reviewed-by: Krzysztof Karas <krzysztof.karas@xxxxxxxxx>

---
Best Regards,
Krzysztof