Re: [PATCH v4 5/8] firmware; qcom: scm: enable QSEECOM on SC8280XP CRD

From: Johan Hovold
Date: Fri Jun 27 2025 - 08:24:06 EST


On Fri, Jun 27, 2025 at 01:54:37AM +0200, Konrad Dybcio wrote:
> On 6/27/25 1:34 AM, Konrad Dybcio wrote:
> > On 6/25/25 12:53 AM, Dmitry Baryshkov wrote:
> >> As reported by Johan, this platform also doesn't currently support
> >> updating of the UEFI variables. In preparation to reworking match list
> >> for QSEECOM mark this platform as supporting QSEECOM with R/O UEFI
> >> variables.
> >>
> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> >> ---
> >> drivers/firmware/qcom/qcom_scm.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
> >> index dbb77c3f69ddaa931e7faa73911207a83634bda1..27ef2497089e11b5a902d949de2e16b7443a2ca4 100644
> >> --- a/drivers/firmware/qcom/qcom_scm.c
> >> +++ b/drivers/firmware/qcom/qcom_scm.c
> >> @@ -2005,6 +2005,7 @@ static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = {
> >> { .compatible = "microsoft,romulus13", },
> >> { .compatible = "microsoft,romulus15", },
> >> { .compatible = "qcom,sc8180x-primus" },
> >> + { .compatible = "qcom,sc8280xp-crd", .data = &qcom_qseecom_ro_uefi, },
> >
> > R/W works for me (tm).. the META version may be (inconclusive) 2605
>
> Looked at the wrong SoC META table.. the build date is 05/25/2023

Could be that my machine was not provisioned properly. Do you boot from
UFS or NVMe?

My fw is also older: 01/10/2022.

Johan