Re: [PATCH v4 2/3] x86/sev: fix error handling in sev_es_efi_map_ghcbs_caas()

[Borislav Petkov]

On Thu, Jun 26, 2025 at 01:40:12PM +0200, Gerd Hoffmann wrote:
> -		if (kernel_map_pages_in_pgd(pgd, pfn, address, 1, pflags))
> -			return 1;
> +		retval = kernel_map_pages_in_pgd(pgd, pfn, address, 1, pflags);
> +		if (retval != 0)
> +			return retval;

Yeah, I'd understand if it made any sense to propagate the error upwards but
this function is called exactly once by efi_setup_page_tables() and all it
needs to return is success/failure which the caller uses on the spot.

So no point in doing any of that nonsense. I'll zap it from the set.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette