Re: [PATCH v6] dt-bindings: net: Convert socfpga-dwmac bindings to yaml

From: Dinh Nguyen
Date: Fri Jun 27 2025 - 07:11:04 EST


On 6/26/25 20:40, Matthew Gerlach wrote:


On 6/26/25 4:48 PM, Rob Herring wrote:
On Fri, Jun 13, 2025 at 03:58:44PM -0700, Matthew Gerlach wrote:
> Convert the bindings for socfpga-dwmac to yaml. Since the original
> text contained descriptions for two separate nodes, two separate
> yaml files were created.

Sigh I just reviewed a conversion from Dinh:

https://lore.kernel.org/all/20250624191549.474686-1-dinguyen@xxxxxxxxxx/

I prefer this one as it has altr,gmii-to-sgmii-2.0.yaml, but I see some
issues compared to Dinh's.

Apologies for the duplicate review. I was planning to convert the dwmac first then add on to the gmii. We should continue with Matthew's version.

I am sorry for my part in the duplicate review. I just rechecked the output of get_maintainers.pl, and Dinh was not listed, and I should have known better.

I am happy to do the work to resolve the differences and resubmit with Dinh as the maintainer.


I'm not the maintainer of this. Maxime Chevalier is. Please don't add me.

Dinh