Re: [PATCH] i2c: scx200_acb: add depends on HAS_IOPORT
From: Wolfram Sang
Date: Fri Jun 27 2025 - 06:21:18 EST
On Sun, Jun 15, 2025 at 11:36:58AM -0700, Randy Dunlap wrote:
> The scx200_acb driver uses inb()/outb() without depending on HAS_IOPORT,
> which leads to build errors since kernel v6.13-rc1:
> commit 6f043e757445 ("asm-generic/io.h: Remove I/O port accessors
> for HAS_IOPORT=n")
>
> Add the HAS_IOPORT dependency to prevent the build errors.
>
> (Found in ARCH=um allmodconfig builds)
>
> drivers/i2c/busses/scx200_acb.c: In function ‘scx200_acb_reset’:
> include/asm-generic/io.h:596:15: error: call to ‘_outb’ declared with attribute error: outb() requires CONFIG_HAS_IOPORT
>
> drivers/i2c/busses/scx200_acb.c:224:26: note: in expansion of macro ‘inb’
> include/asm-generic/io.h:542:14: error: call to ‘_inb’ declared with attribute error: inb()) requires CONFIG_HAS_IOPORT
> 224 | status = inb(ACBST);
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxxxx>
> Cc: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>
> Cc: Jim Cromie <jim.cromie@xxxxxxxxx>
> Cc: Andi Shyti <andi.shyti@xxxxxxxxxx>
> Cc: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Cc: linux-i2c@xxxxxxxxxxxxxxx
Applied to for-current, thanks!