Re: [PATCH v2 5/5] fbdev/simplefb: Add support for interconnect paths

From: Javier Martinez Canillas
Date: Fri Jun 27 2025 - 06:03:04 EST


"Luca Weiss" <luca.weiss@xxxxxxxxxxxxx> writes:

> On Fri Jun 27, 2025 at 9:56 AM CEST, Javier Martinez Canillas wrote:

[...]

>> These two functions contain the same logic that you are using in the
>> simpledrm driver. I wonder if could be made helpers so that the code
>> isn't duplicated in both drivers.
>
> I believe most resource handling code (clocks, regulators,
> power-domains, plus now interconnect) should be pretty generic between
> the two.
>

Yeah.

>>
>> But in any case it could be a follow-up of your series I think.
>
> To be fair, I don't think I'll work on this, I've got plenty of Qualcomm
> SoC-specific bits to work on :)
>

That's OK :) It was just a drive by comment, but as said I don't think
that this code duplication should be a blocker for this patch series.
--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat