回覆: [PATCH 3/7] dt-bindings: pci: Add document for ASPEED PCIe RC

[Jacky Chou]

> > +  reset-names:
> > +    items:
> > +      - const: h2x
> > +      - const: perst
> > +
> > +  msi-parent: true
> > +
> > +  msi_address:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: MSI address
> 
> What's this for?
> 

This is used for the kernel assigns the MSI address to PCIe device.
The address is fixed in HW. I think I will remove this and add hard
code in driver in next version.

> > +
> > +  aspeed,ahbc:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description: Phandle to ASPEED AHBC syscon.
> > +
> > +  aspeed,pciecfg:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description: Phandle to ASPEED PCIe configuration syscon.
> > +
> > +  aspeed,pciephy:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description: Phandle to ASPEED PCIe PHY syscon.
> 
> Use the phy binding and make the phy control a separate driver.
> 

Do you mean to create a PHY driver with devm_phy_create()?
Then, the PCIe RC driver uses the API of PHY to call phy_ops?

Thanks,
Jacky