Re: [PATCH v2 1/5] drm/mipi-dsi: Add dev_is_mipi_dsi function

From: Javier Martinez Canillas
Date: Fri Jun 27 2025 - 05:34:34 EST


Maxime Ripard <mripard@xxxxxxxxxx> writes:

> On Fri, Jun 27, 2025 at 11:04:16AM +0200, Javier Martinez Canillas wrote:
>> Maxime Ripard <mripard@xxxxxxxxxx> writes:
>>

[...]

>>
>> Usually I prefer to have static inline functions instead of macros to have
>> type checking. I see that this header has a mix of both, so I don't have a
>> strong opinion on what to use in this case.
>>
>> Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
>
> Thanks for your review!
>
> For the record, it's also how the platform bus defines its equivalent
> macro, so that's why I went with it.
>

Got it. I think is OK.

> Maxime

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat