Re: [PATCH v1 1/2] firmware: sysfb: Unorphan sysfb files

[Javier Martinez Canillas]

Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes:

> On Fri, Jun 27, 2025 at 10:50:48AM +0200, Javier Martinez Canillas wrote:
>> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes:
>> 
>> > The commit d391c5827107 ("drivers/firmware: move x86 Generic
>> > System Framebuffers support") moved some code to the common
>> > folders and effectively orphaned it without any reason. Put
>> > it back under DRM MISC record.
>> 
>> What do you mean that it was "orphaned without any reason" ? There were no
>> regex matchs for the old file paths in MAINTAINERS either before that commit.
>
> There were maintainers for that code before. The change in question dropped that.
>
> [((bf44e8cecc03...))]$ scripts/get_maintainer.pl -f arch/x86/kernel/sysfb*
> Thomas Gleixner <tglx@xxxxxxxxxxxxx> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
> Ingo Molnar <mingo@xxxxxxxxxx> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
> Borislav Petkov <bp@xxxxxxxxx> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
> x86@xxxxxxxxxx (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
> "H. Peter Anvin" <hpa@xxxxxxxxx> (reviewer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
> linux-kernel@xxxxxxxxxxxxxxx (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT))
>
> [((d391c5827107...))]$ scripts/get_maintainer.pl -f drivers/firmware/sysfb*
> linux-kernel@xxxxxxxxxxxxxxx (open list)
>

That's just because there is an entry for arch/x86/. The problem then is
that there isn't an entry for drivers/firmware. It was orphaned then just
because it was moved to a directory that has no entry in MAINTAINERS.

> See the difference?
>

There is no need to have such a rude tone.

> ...
>
>> > +F:	drivers/firmware/sysfb*.c
>
>> I would prefer these to be in the "DRM DRIVER FOR FIRMWARE FRAMEBUFFERS"
>> entry instead of "DRM DRIVERS" since the former is what has most of the
>> code for the sysfb infrastructure.
>
> Then do it, please, fix the above.
>

Part of the review process is to give feedback to patch authors. I don't
understand why you expect me to fix an issue you brought up just because
I ask you to rework your patch a little.

> -- 
> With Best Regards,
> Andy Shevchenko
>
>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat