Re: [PATCH v2 09/10] dt-bindings: clock: airoha: Document support for AN7583 clock

[Krzysztof Kozlowski]

On Tue, Jun 17, 2025 at 03:04:52PM +0200, Christian Marangi wrote:
> Document support for Airoha AN7583 clock. This is based on the EN7523
> clock schema with the new requirement of the "airoha,chip-scu"
> (previously optional for EN7581).
> 
> Add additional binding for additional clock and reset lines.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> ---
>  .../bindings/clock/airoha,en7523-scu.yaml     |  9 +++
>  include/dt-bindings/clock/en7523-clk.h        |  3 +
>  .../dt-bindings/reset/airoha,an7583-reset.h   | 61 +++++++++++++++++++
>  3 files changed, 73 insertions(+)
>  create mode 100644 include/dt-bindings/reset/airoha,an7583-reset.h
> 
> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> index bce77a14c938..be9759b86fdc 100644
> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> @@ -32,6 +32,7 @@ properties:
>        - enum:
>            - airoha,en7523-scu
>            - airoha,en7581-scu
> +          - airoha,an7583-scu
>  
>    reg:
>      items:
> @@ -82,6 +83,14 @@ allOf:
>          reg:
>            maxItems: 1
>  
> +  - if:
> +      properties:
> +        compatible:
> +          const: airoha,an7583-scu
> +    then:
> +      required:
> +        - airoha,chip-scu

Not really. SCU does not need phandle to SCU.

Best regards,
Krzysztof