Re: [PATCH] usb: gadget: u_serial: remove some dead code
From: Dan Carpenter
Date: Thu Jun 26 2025 - 09:21:53 EST
On Thu, Jun 26, 2025 at 11:53:05AM +0530, Prashanth K wrote:
>
>
> On 6/25/2025 8:51 PM, Dan Carpenter wrote:
> > There is no need to check if "port" is NULL. We already verified that it
> > is non-NULL. It's a stack variable and can't be modified by a different
> > thread. Delete this dead code.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > ---
>
> Perhaps you could add Closes and Fixes tag, but its up to you.
Fixes is only for bugs. If I put a Closes tag, then I'd have to give
myself reported by credit as well which is just being greedy for tags. :P
regards,
dan carpenter