Re: [RFC PATCH v4 4/8] x86/apic: Introduce Remote Action Request Operations

[Kirill A. Shutemov]

On Thu, Jun 19, 2025 at 04:03:56PM -0400, Rik van Riel wrote:
> From: Yu-cheng Yu <yu-cheng.yu@xxxxxxxxx>
> 
> RAR TLB flushing is started by sending a command to the APIC.
> This patch adds Remote Action Request commands.
> 
> Because RAR_VECTOR is hardcoded at 0xe0, POSTED_MSI_NOTIFICATION_VECTOR
> has to be lowered to 0xdf, reducing the number of available vectors by
> 13.
> 
> [riel: refactor after 6 years of changes, lower POSTED_MSI_NOTIFICATION_VECTOR]

But why? Because it is used as FIRST_SYSTEM_VECTOR?

> Signed-off-by: Yu-cheng Yu <yu-cheng.yu@xxxxxxxxx>
> Signed-off-by: Rik van Riel <riel@xxxxxxxxxxx>
> ---
>  arch/x86/include/asm/apicdef.h     | 1 +
>  arch/x86/include/asm/irq_vectors.h | 7 ++++++-
>  arch/x86/include/asm/smp.h         | 1 +
>  arch/x86/kernel/apic/ipi.c         | 5 +++++
>  arch/x86/kernel/apic/local.h       | 3 +++
>  5 files changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/apicdef.h b/arch/x86/include/asm/apicdef.h
> index 094106b6a538..b152d45af91a 100644
> --- a/arch/x86/include/asm/apicdef.h
> +++ b/arch/x86/include/asm/apicdef.h
> @@ -92,6 +92,7 @@
>  #define		APIC_DM_LOWEST		0x00100
>  #define		APIC_DM_SMI		0x00200
>  #define		APIC_DM_REMRD		0x00300
> +#define		APIC_DM_RAR		0x00300

Hm. Do we conflict with APIC_DM_REMRD here?

>  #define		APIC_DM_NMI		0x00400
>  #define		APIC_DM_INIT		0x00500
>  #define		APIC_DM_STARTUP		0x00600

-- 
  Kiryl Shutsemau / Kirill A. Shutemov