Re: [PATCH v4 3/4] media: dt-bindings: Add qcom,msm8939-camss

[Krzysztof Kozlowski]

On 06/06/2025 12:46, Vladimir Zapolskiy wrote:
> Hello Vincent.
> 
> On 6/2/25 20:27, Vincent Knecht via B4 Relay wrote:
>> From: Vincent Knecht <vincent.knecht@xxxxxxxxxx>
>>
>> Add bindings for qcom,msm8939-camss in order to support the camera
>> subsystem for MSM8939.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> Signed-off-by: Vincent Knecht <vincent.knecht@xxxxxxxxxx>
>> ---
>>   .../bindings/media/qcom,msm8939-camss.yaml         | 254 +++++++++++++++++++++
>>   1 file changed, 254 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8939-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8939-camss.yaml
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..59bf16888a8235495a2080e512ce179583bcd25d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/qcom,msm8939-camss.yaml
>> @@ -0,0 +1,254 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/qcom,msm8939-camss.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm MSM8939 Camera Subsystem (CAMSS)
>> +
>> +maintainers:
>> +  - Vincent Knecht <vincent.knecht@xxxxxxxxxx>
>> +
>> +description:
>> +  The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms
>> +
>> +properties:
>> +  compatible:
>> +    const: qcom,msm8939-camss
>> +
>> +  reg:
>> +    maxItems: 11
>> +
>> +  reg-names:
>> +    items:
>> +      - const: csid0
>> +      - const: csid1
>> +      - const: csid2
>> +      - const: csiphy0
>> +      - const: csiphy0_clk_mux
>> +      - const: csiphy1
>> +      - const: csiphy1_clk_mux
>> +      - const: csi_clk_mux
>> +      - const: ispif
>> +      - const: vfe0
>> +      - const: vfe0_vbif
> 
> Please sort the list alphanumerically, accorting to the ASCII character set
> the underscore symbol precedes lower case letters.


This messes up with preferred style, as I described multiple times now.
You need to stop this sorting madness - asking people to sort values by
some own rules.

Best regards,
Krzysztof