Re: [PATCH RESEND 0/3] Input: convert GPIO chips to using new value setters

From: Bartosz Golaszewski
Date: Thu Jun 26 2025 - 03:37:30 EST


On Thu, Jun 26, 2025 at 7:54 AM Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
>
> Hi Bartosz,
>
> On Mon, Jun 23, 2025 at 09:59:07AM +0200, Bartosz Golaszewski wrote:
> > On Tue, Jun 10, 2025 at 11:40 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > >
> > > Never got any further feedback on this series last cycle. Resending for
> > > v6.17.
> > >
> > > struct gpio_chip now has callbacks for setting line values that return
> > > an integer, allowing to indicate failures. We're in the process of
> > > converting all GPIO drivers to using the new API. This series converts
> > > all the GPIO controllers under drivers/input/.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> > > ---
> > > Bartosz Golaszewski (3):
> > > Input: ad7879 - use new GPIO line value setter callbacks
> > > Input: adp5588 - use new GPIO line value setter callbacks
> > > Input: adp5589 - use new GPIO line value setter callbacks
> > >
> > > drivers/input/keyboard/adp5588-keys.c | 9 +++++----
> > > drivers/input/keyboard/adp5589-keys.c | 11 ++++++-----
> > > drivers/input/touchscreen/ad7879.c | 11 +++++++----
> > > 3 files changed, 18 insertions(+), 13 deletions(-)
> > > ---
> > > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> > > change-id: 20250331-gpiochip-set-rv-input-bc12818c5732
> > >
> > > Best regards,
> > > --
> > > Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> > >
> >
> > Dmitry,
> >
> > Could you please pick these patches up for v6.17? They already missed
> > the last cycle and we're on track to complete the conversion in the
> > next one so I'd really appreciate these going upstream in the next
> > merge window.
>
> My apologies, I was hoping Nuno's conversion of these drivers to MFD
> would be accepted and these versions be simply removed...
>
> I acked all 3.
>
> Thanks.
>
> --
> Dmitry

Does this mean you prefer me to take them through the GPIO tree? Do
you want an immutable branch?

Bart