Re: [PATCH 1/2] dt-bindings: arm: qcom: Add bindings for IQ8 EVK board

[Bjorn Andersson]

On Mon, Jun 23, 2025 at 06:34:19PM +0530, Umang Chheda wrote:
> QCS8275 is another SoC under IQ8 series of SoCs. Unlike QCS8300
> which has safety features, it doesn't have safety monitoring feature
> of Safety-Island(SAIL) subsystem, which affects thermal management.
> 

QCS8300 and QCS8275 are both the "Monaco" SoC, with some differences in
which nodes are "okay" and "disabled", and as you say here some side
effects thereof.

Describing these as "Monaco" and "Monaco with Sail" would lend itself
for a better structure.

> qcs8275-iq-8275-evk board is based on QCS8275 SOC.
> 
> Signed-off-by: Umang Chheda <umang.chheda@xxxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index b14206d11f8b..19823bc91a3b 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -54,6 +54,7 @@ description: |
>          msm8998
>          qcs404
>          qcs615
> +        qcs8275

Please add "monaco" instead.

>          qcs8300
>          qcs8550
>          qcm2290
> @@ -935,6 +936,12 @@ properties:
>            - const: qcom,qcs404-evb
>            - const: qcom,qcs404
>  
> +      - items:
> +          - enum:
> +              - qcom,qcs8275-iq-8275-evk

Please use the qcom,monaco- prefix. Is qcom,monaco-evk unique enough?
We can sync up offline on this.

> +          - const: qcom,qcs8275
> +          - const: qcom,qcs8300

Please replace these two with just qcom,monaco.

Regards,
Bjorn

> +
>        - items:
>            - enum:
>                - qcom,qcs8300-ride
> -- 
> 2.25.1
>