Re: [PATCHv2 01/12] x86/tdx: Consolidate TDX error handling

[Huang, Kai]

On Wed, 2025-06-25 at 10:58 -0700, Hansen, Dave wrote:
> > -/*
> > - * TDX module SEAMCALL leaf function error codes
> > - */
> > -#define TDX_SUCCESS		0ULL
> > -#define TDX_RND_NO_ENTROPY	0x8000020300000000ULL
> 
> Kai, you were responsible for this nugget. What do you think of this patch?

(sorry for getting into this late)

I am 100% with consolidating TDX definitions across KVM and the core kernel,
so thanks Kirill for doing this.

But as you suggested, I think it's better to split this patch into two:

 - One patch to just move error code from tdx_error.h in KVM and TDX guest
code to <asm/tdx_error.h>.
 - One patch to further introduce those helpers (tdx_rnd_no_entropy() etc)
and actually use them in the code.

It will be easier to review anyway.