Re: [PATCH 1/2] Move FCH header to a location accessible by all archs

From: Andi Shyti
Date: Wed Jun 25 2025 - 17:59:57 EST


Hi,

On Thu, Jun 12, 2025 at 10:36:31AM +0200, Hans de Goede wrote:
> Hi,
>
> On 10-Jun-25 10:58 PM, Mario Limonciello wrote:
> > From: Mario Limonciello <mario.limonciello@xxxxxxx>
> >
> > A new header fch.h was created to store registers used by different AMD
> > drivers. This header was included by i2c-piix4 in
> > commit 624b0d5696a8 ("i2c: piix4, x86/platform: Move the SB800 PIIX4 FCH
> > definitions to <asm/amd/fch.h>"). To prevent compile failures on non-x86
> > archs i2c-piix4 was set to only compile on x86 by commit 7e173eb82ae9717
> > ("i2c: piix4: Make CONFIG_I2C_PIIX4 dependent on CONFIG_X86").
> > This was not a good decision because loongarch and mips both actually
> > support i2c-piix4 and set it enabled in the defconfig.
> >
> > Move the header to a location accessible by all architectures.
> >
> > Fixes: 624b0d5696a89 ("i2c: piix4, x86/platform: Move the SB800 PIIX4 FCH definitions to <asm/amd/fch.h>")
> > Suggested-by: Hans de Goede <hansg@xxxxxxxxxx>
> > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hansg@xxxxxxxxxx>

I don't see this series in yet. I thought you were taking it,
shall I take it through i2c?

Andi