Re: [PATCH net-next 6/7] net: splice: Drop nr_pages_max initialization

[Michal Luczaj]

On 6/25/25 12:06, Simon Horman wrote:
> On Tue, Jun 24, 2025 at 11:53:53AM +0200, Michal Luczaj wrote:
>> splice_pipe_desc::nr_pages_max was initialized unnecessary in commit
>> 41c73a0d44c9 ("net: speedup skb_splice_bits()"). spd_fill_page() compares
>> spd->nr_pages against a constant MAX_SKB_FRAGS, which makes setting
>> nr_pages_max redundant.
>>
>> Remove the assignment. No functional change intended.
>>
>> Signed-off-by: Michal Luczaj <mhal@xxxxxxx>
> 
> Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
> 
>> ---
>> Probably the same thing in net/smc/smc_rx.c:smc_rx_splice()?
> 
> Yes, it seems so to me.

OK, tomorrow I'll post v2 with smc_rx_splice() taken care of.

Thanks,
Michal