Re: [PATCH v14 10/32] x86/resctrl: Add support to enable/disable AMD ABMC feature
From: Moger, Babu
Date: Wed Jun 25 2025 - 15:51:05 EST
Hi Reinette,
On 6/24/25 17:37, Reinette Chatre wrote:
> Hi Babu,
>
> On 6/13/25 2:04 PM, Babu Moger wrote:
>> +/**
>> + * resctrl_arch_mbm_cntr_assign_set() - Configure the MBM counter assignment mode.
>> + * @r: Pointer to the resource structure.
>> + * @enable: Set to true to enable, false to disable the assignment mode.
>> + *
>> + * Return:
>> + * 0 on success, non-zero on failure.
>
> * 0 on success, <0 on failure.
Sure.
0 on success, < 0 on error.
>
> (Just to be specific that it will be negative. Could also be "on error" to match
> similar in same file, but resctrl is not consistent in this regard.)
>
--
Thanks
Babu Moger