Re: [PATCH v14 08/32] x86,fs/resctrl: Consolidate monitoring related data from rdt_resource

[Moger, Babu]

Hi Reinette,

On 6/24/25 16:32, Reinette Chatre wrote:
> Hi Babu,
> 
> On 6/13/25 2:04 PM, Babu Moger wrote:
> 
> ...
> 
>> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
>> index bbe57eff962b..22766b8b670b 100644
>> --- a/include/linux/resctrl.h
>> +++ b/include/linux/resctrl.h
>> @@ -255,38 +255,46 @@ enum resctrl_schema_fmt {
>>  	RESCTRL_SCHEMA_RANGE,
>>  };
>>  
>> +/**
>> + * struct resctrl_mon - Monitoring related data of a resctrl resource.
>> + * @num_rmid:		Number of RMIDs available.
>> + * @mbm_cfg_mask:	Memory transactions that can be tracked when bandwidth
>> + *			monitoring events are configured.
> 
> "are configured" -> "can be configured" (like it was before). This is a property
> that is discovered from hardware. The feature need not be in use for the property
> to be valid.

Sure.


> Also, this version switches "Bandwidth sources" -> "Memory transactions". I think this
> is a good change but it may be unexpected. Perhaps a snippet in changelog to
> point out the motivation for this change: "Also switch "bandwidth sources" term
> to "memory transactions" to use consistent term within resctrl for related monitoring
> features". Please feel free to improve.
> 

Sure. This is how it looks now.

"The cache allocation and memory bandwidth allocation feature properties
are consolidated into struct resctrl_cache and struct resctrl_membw
respectively.

In preparation for more monitoring properties that will clobber the
existing resource struct more, re-organize the monitoring specific
properties to also be in a separate structure.

Also switch "bandwidth sources" term to "memory transactions" to use
consistent term within resctrl for related monitoring features."

-- 
Thanks
Babu Moger