Re: [PATCH v4 06/22] x86/mce/amd: Remove return value for mce_threshold_{create,remove}_device()

[Nikolay Borisov]

On 6/24/25 17:16, Yazen Ghannam wrote:
> The return values are not checked, so set return type to 'void'.
>
> Also, move function declarations to internal.h, since these functions are
> only used within the MCE subsystem.
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>


Realistically the only case when this code can fail is if the machine is 
tight on memory and a cpu is brought on. So the wider question is should 
such a situation fail the hotplug event? Likely something else in the 
chain would have failed up earlier, so I guess the answer is no.

In any case LGTM:

Reviewed-by: Nikolay Borisov <nik.borisov@xxxxxxxx>