Re: [PATCH] staging: sm750fb: Mark g_fbmode as a pointer to const pointer
From: Dan Carpenter
Date: Wed Jun 25 2025 - 07:19:55 EST
On Wed, Jun 25, 2025 at 10:40:26AM +0545, Pratibimba Khadka wrote:
> Fixes a checkpatch warning:
> WARNING: static const char * array should probably be static const char * const
>
> The array `g_fbmode` contains constant string pointers that are not
> supposed to be modified. By declaring it as `const char * const`,
> both the string literals and the pointers themselves are protected
> from accidental modification, which improves code safety and clarity.
>
You need to compile test code before sending it. It can't be changed
from being a NULL pointer now so it breaks.
regards,
dan carpenter