Re: [PATCH v3 3/6] spi: spi-fsl-dspi: Stub out DMA functions

[James Clark]

On 24/06/2025 6:16 pm, Arnd Bergmann wrote:
> On Tue, Jun 24, 2025, at 18:29, Frank Li wrote:
> > On Tue, Jun 24, 2025 at 11:35:33AM +0100, James Clark wrote:
> > > This will allow the build to succeed with !CONFIG_HAS_DMA, either due to
> > > a randconfig build test or when the target only uses one of the non-DMA
> >
> > I supposed you met kbuild error. If yes, can you add kbuild build report
> > tags.
>
> Actually I would suggest making it a dependency on CONFIG_DMA_ENGINE
> instead of CONFIG_HAS_DMA, since that is the more relevant symbol.

Makes sense.

> It would also be simpler to enforce this in Kconfig if we only
> care about users that use the DMA support.
>
>        Arnd

But most of the devices supported by the driver don't do any DMA. That 
was the reason to stub them out rather than add the Kconfig depends.