Re: [PATCH v1 1/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

[Johan Hovold]

On Wed, Jun 25, 2025 at 12:41:20AM +0200, Aleksandrs Vinarskis wrote:
> pm8010 is a camera specific PMIC, and may not be present on some
> devices. These may instead use a dedicated vreg for this purpose (Dell
> XPS 9345, Dell Inspiron..) or use USB webcam instead of a MIPI one
> alltogether (Lenovo Thinbook 16, Lenovo Yoga..).
> 
> Disable pm8010 by default, let platforms that actually have one onboard
> enable it instead.
> 
> This fixes dmesg errors of PMIC failing to probe, and on Dell XPS 9345
> fixes the issue of power button not working as power off/suspend (only
> long press cuts the power).
> 
> Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")
> 

Nit: There shouldn't be a new line here after the Fixes tag.

Not sure how this breaks the power button on the XPS, but sounds like
this one should be marked for stable backport:

Cc: stable@xxxxxxxxxxxxxxx

> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@xxxxxxxxx>

Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx>

Johan