[PATCH v2] wifi: rsi: Use usb_endpoint_xfer_bulk() rather than duplicating its implementation

[Markus Elfring]

From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 25 Jun 2025 08:46:02 +0200

Reuse existing functionality from usb_endpoint_xfer_bulk() instead of
keeping duplicate source code.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---

V2:
Another change possibility was taken better into account for the USB API.


 drivers/net/wireless/rsi/rsi_91x_usb.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless/rsi/rsi_91x_usb.c
index dccc139cabb2..31707b543c19 100644
--- a/drivers/net/wireless/rsi/rsi_91x_usb.c
+++ b/drivers/net/wireless/rsi/rsi_91x_usb.c
@@ -122,8 +122,7 @@ static int rsi_find_bulk_in_and_out_endpoints(struct usb_interface *interface,
 
 		if (!dev->bulkin_endpoint_addr[bin_found] &&
 		    (endpoint->bEndpointAddress & USB_DIR_IN) &&
-		    ((endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) ==
-		    USB_ENDPOINT_XFER_BULK)) {
+		    usb_endpoint_xfer_bulk(endpoint)) {
 			buffer_size = endpoint->wMaxPacketSize;
 			dev->bulkin_size[bin_found] = buffer_size;
 			dev->bulkin_endpoint_addr[bin_found] =
@@ -133,8 +132,7 @@ static int rsi_find_bulk_in_and_out_endpoints(struct usb_interface *interface,
 
 		if (!dev->bulkout_endpoint_addr[bout_found] &&
 		    !(endpoint->bEndpointAddress & USB_DIR_IN) &&
-		    ((endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) ==
-		    USB_ENDPOINT_XFER_BULK)) {
+		    usb_endpoint_xfer_bulk(endpoint)) {
 			buffer_size = endpoint->wMaxPacketSize;
 			dev->bulkout_endpoint_addr[bout_found] =
 				endpoint->bEndpointAddress;
-- 
2.50.0