Re: [PATCH (REPOST)] hfs: don't use BUG() when we can continue

[Tetsuo Handa]

Matthew, any comments?

On 2024/12/05 23:14, Tetsuo Handa wrote:
> On 2024/12/05 22:59, Matthew Wilcox wrote:
>> On Thu, Dec 05, 2024 at 10:45:11PM +0900, Tetsuo Handa wrote:
>>> syzkaller can mount crafted filesystem images.
>>> Don't crash the kernel when we can continue.
>>
>> The one in hfs_test_inode() makes sense, but we should never get to
>> hfs_release_folio() or hfs_write_inode() with a bad inode, even with a
>> corrupted fs.  Right?
> 
> Unfortunately, https://syzkaller.appspot.com/bug?extid=97e301b4b82ae803d21b
> reports that we can reach hfs_write_inode() with a corrupted filesystem.
> If we should never get to hfs_write_inode(), how do we want to handle
> this problem? Is someone familiar with hfs enough to perform an in-kernel
> fsck upon mounting?
>