Re: [PATCH net-next v2 3/8] net/mlx5: HWS, Refactor and export rule skip logic

[Yevgeny Kliteynik]

Hi Simon,
Thanks for reviewing the patches!

On 24-Jun-25 21:38, Simon Horman wrote:
> On Sun, Jun 22, 2025 at 08:22:21PM +0300, Mark Bloch wrote:
> > From: Vlad Dogaru <vdogaru@xxxxxxxxxx>
> >
> > The bwc layer will use `mlx5hws_rule_skip` to keep track of numbers of
> > RX and TX rules individually, so export this function for future usage.
> >
> > While we're in there, reduce nesting by adding a couple of early return
> > statements.
>
> I'm all for reducing nesting. But this patch has two distinct changes.
> Please consider splitting it into two patches.

Not sure I'd send the refactor thing alone - it isn't worth the effort
IMHO... But since I'm already in here - sure, will sent it in a separate
patch.


> > Signed-off-by: Vlad Dogaru <vdogaru@xxxxxxxxxx>
> > Reviewed-by: Yevgeny Kliteynik <kliteyn@xxxxxxxxxx>
> > Signed-off-by: Mark Bloch <mbloch@xxxxxxxxxx>
>
> ...