Re: [PATCH 2/2] KVM: SVM: Simplify MSR interception logic for IA32_XSS MSR

From: Sean Christopherson
Date: Tue Jun 24 2025 - 18:49:09 EST


On Thu, Jun 12, 2025, Chao Gao wrote:
> Use svm_set_intercept_for_msr() directly to configure IA32_XSS MSR
> interception, ensuring consistency with other cases where MSRs are
> intercepted depending on guest caps and CPUIDs.
>
> No functional change intended.
>
> Signed-off-by: Chao Gao <chao.gao@xxxxxxxxx>
> ---
> With this patch applied, svm_enable_intercept_for_msr() has no user.
> Should it be removed?

I'd say leave it. If it's a static inline, then there's no dead overhead in the
binary, and I like having parity between VMX and SVM.