RE: [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in Mellanox drivers

[David Thompson]

> -----Original Message-----
> From: Alok Tiwari <alok.a.tiwari@xxxxxxxxxx>
> Sent: Sunday, June 22, 2025 3:29 AM
> To: hansg@xxxxxxxxxx; ilpo.jarvinen@xxxxxxxxxxxxxxx; David Thompson
> <davthompson@xxxxxxxxxx>; Michael Shych <michaelsh@xxxxxxxxxx>; Vadim
> Pasternak <vadimp@xxxxxxxxxx>; platform-driver-x86@xxxxxxxxxxxxxxx
> Cc: alok.a.tiwari@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in
> Mellanox drivers
> 
> This commit corrects several minor typographical errors in comments and error
> messages across multiple Mellanox platform driver.
> Fixed spelling of "thresholds", "region", "platform", "default", and removed
> redundant spaces in comment strings and error logs.
> 
> These changes are cosmetic and do not affect runtime behavior.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@xxxxxxxxxx>
> ---
>  drivers/platform/mellanox/mlxbf-tmfifo.c |  2 +-
>  drivers/platform/mellanox/mlxreg-dpu.c   |  2 +-
>  drivers/platform/mellanox/mlxreg-lc.c    | 10 +++++-----
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c
> b/drivers/platform/mellanox/mlxbf-tmfifo.c
> index aae99adb29eb0..6264379d96907 100644
> --- a/drivers/platform/mellanox/mlxbf-tmfifo.c
> +++ b/drivers/platform/mellanox/mlxbf-tmfifo.c
> @@ -1287,7 +1287,7 @@ static void mlxbf_tmfifo_get_cfg_mac(u8 *mac)
>  		ether_addr_copy(mac, mlxbf_tmfifo_net_default_mac);  }
> 
> -/* Set TmFifo thresolds which is used to trigger interrupts. */
> +/* Set TmFifo thresholds which is used to trigger interrupts. */
>  static void mlxbf_tmfifo_set_threshold(struct mlxbf_tmfifo *fifo)  {
>  	u64 ctl;
> diff --git a/drivers/platform/mellanox/mlxreg-dpu.c
> b/drivers/platform/mellanox/mlxreg-dpu.c
> index 52260106a9f16..39f89c47144a2 100644
> --- a/drivers/platform/mellanox/mlxreg-dpu.c
> +++ b/drivers/platform/mellanox/mlxreg-dpu.c
> @@ -483,7 +483,7 @@ static int mlxreg_dpu_config_init(struct mlxreg_dpu
> *mlxreg_dpu, void *regmap,
>  							  mlxreg_dpu->io_data,
>  							  sizeof(*mlxreg_dpu-
> >io_data));
>  		if (IS_ERR(mlxreg_dpu->io_regs)) {
> -			dev_err(dev, "Failed to create regio for client %s at bus
> %d at addr 0x%02x\n",
> +			dev_err(dev, "Failed to create region for client %s at bus
> %d at
> +addr 0x%02x\n",
>  				data->hpdev.brdinfo->type, data->hpdev.nr,
>  				data->hpdev.brdinfo->addr);
>  			return PTR_ERR(mlxreg_dpu->io_regs); diff --git
> a/drivers/platform/mellanox/mlxreg-lc.c b/drivers/platform/mellanox/mlxreg-
> lc.c
> index aee395bb48ae4..8eef3d990d1ae 100644
> --- a/drivers/platform/mellanox/mlxreg-lc.c
> +++ b/drivers/platform/mellanox/mlxreg-lc.c
> @@ -57,9 +57,9 @@ enum mlxreg_lc_state {
>   * @dev: platform device;
>   * @lock: line card lock;
>   * @par_regmap: parent device regmap handle;
> - * @data: pltaform core data;
> + * @data: platform core data;
>   * @io_data: register access platform data;
> - * @led_data: LED platform data ;
> + * @led_data: LED platform data;
>   * @mux_data: MUX platform data;
>   * @led: LED device;
>   * @io_regs: register access device;
> @@ -171,7 +171,7 @@ static int mlxreg_lc_chan[] = {
>  	0x4e, 0x4f
>  };
> 
> -/* Defaul mux configuration. */
> +/* Default mux configuration. */
>  static struct mlxcpld_mux_plat_data mlxreg_lc_mux_data[] = {
>  	{
>  		.chan_ids = mlxreg_lc_chan,
> @@ -181,7 +181,7 @@ static struct mlxcpld_mux_plat_data
> mlxreg_lc_mux_data[] = {
>  	},
>  };
> 
> -/* Defaul mux board info. */
> +/* Default mux board info. */
>  static struct i2c_board_info mlxreg_lc_mux_brdinfo = {
>  	I2C_BOARD_INFO("i2c-mux-mlxcpld", 0x32),  }; @@ -758,7 +758,7 @@
> mlxreg_lc_config_init(struct mlxreg_lc *mlxreg_lc, void *regmap,
>  		platform_device_register_resndata(dev, "mlxreg-io", data-
> >hpdev.nr, NULL, 0,
>  						  mlxreg_lc->io_data,
> sizeof(*mlxreg_lc->io_data));
>  		if (IS_ERR(mlxreg_lc->io_regs)) {
> -			dev_err(dev, "Failed to create regio for client %s at bus
> %d at addr 0x%02x\n",
> +			dev_err(dev, "Failed to create region for client %s at bus
> %d at
> +addr 0x%02x\n",
>  				data->hpdev.brdinfo->type, data->hpdev.nr,
>  				data->hpdev.brdinfo->addr);
>  			err = PTR_ERR(mlxreg_lc->io_regs);
> --
> 2.46.0

Reviewed-by: David Thompson <davthompson@xxxxxxxxxx>