Re: [PATCH v2 5/5] mm/madvise: eliminate very confusing manipulation of prev VMA

[Lorenzo Stoakes]

On Tue, Jun 24, 2025 at 07:57:09PM +0200, Vlastimil Babka wrote:
> On 6/24/25 15:16, Lorenzo Stoakes wrote:
> > vma may have been updated (in the modify call in madvise_update_vma()), so
> > we can't assign prev = vma, we must first reassign vma to
> > madv_behavior->vma to account for this, before setting prev = vma.
>
> So glad we eliminated very confusing manipulation of prev VMA :) sigh...
>
> LGTM (not worth much it seems...)

Appreciated thanks! (this was really quite subtle and we all missed it, so don't
worry :)