Re: [PATCH v8 4/9] rust: acpi: add `acpi::DeviceId` abstraction
From: Rafael J. Wysocki
Date: Tue Jun 24 2025 - 13:56:56 EST
On Sat, Jun 21, 2025 at 12:06 AM Danilo Krummrich <dakr@xxxxxxxxxx> wrote:
>
> On Fri, Jun 20, 2025 at 04:24:25PM +0100, Igor Korotin wrote:
> > `acpi::DeviceId` is an abstraction around `struct acpi_device_id`.
> >
> > This is used by subsequent patches, in particular the i2c driver
> > abstractions, to create ACPI device ID tables.
>
> I think this should say something like
>
> "Enable drivers to build ACPI device ID tables, to be consumed by the
> corresponding bus abstractions, such as platform or I2C."
>
> instead.
>
> If we agree, I can change it when applying the patch -- no need to resend.
>
> >
> > Signed-off-by: Igor Korotin <igor.korotin.linux@xxxxxxxxx>
>
> @Rafael: Can I get an ACK for this one, such that I can take it together with
> all other patches through the driver-core tree?
I don't see anything objectionable in it, even though Rust code is
still kind of outside my confidence zone ATM.
Anyway, please feel free to add
Acked-by: Rafael J. Wysocki <rafael@xxxxxxxxxx>
to this.
Thanks!