Re: [PATCH v2 3/4] mm, madvise: move madvise_set_anon_name() down the file
From: Vlastimil Babka
Date: Tue Jun 24 2025 - 12:47:51 EST
On 6/24/25 16:05, David Hildenbrand wrote:
> On 24.06.25 15:03, Vlastimil Babka wrote:
>
> Personally, I would squash that into #4, given that #4 is pretty small ;)
>
> Acked-by: David Hildenbrand <david@xxxxxxxxxx>
Right, the advantages of pure move commits is that git diff can colorize
them so it's immediately obvious, and git blame -C or -M can also recognize
pure moves and ignore them. Mixing moves with changes tends to break these
heuristics. But if Andrew wants to squash, feel free.