Re: [PATCH] mei: vsc: Remove unused irq functions

From: Greg KH
Date: Tue Jun 24 2025 - 11:42:19 EST


On Tue, Jun 24, 2025 at 11:17:24AM +0000, Dr. David Alan Gilbert wrote:
> * Hans de Goede (hdegoede@xxxxxxxxxx) wrote:
> > Hi David,
> >
> > On 17-Jun-25 2:34 AM, linux@xxxxxxxxxxx wrote:
> > > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > >
> > > vsc_tp_request_irq() and vsc_tp_free_irq() last uses were removed in 2024
> > > by
> > > commit 9b5e045029d8 ("mei: vsc: Don't stop/restart mei device during system
> > > suspend/resume")
> > >
> > > Remove them.
> > >
> > > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> >
> > Alexander pointed me at this patch because I just posted
> > almost the same patch:
> >
> > https://lore.kernel.org/lkml/20250623085052.12347-2-hansg@xxxxxxxxxx/
> >
> > Normally I would say lets go with your (David's) version since
> > you posted your patch first.
> >
> > But your patch is missing the removal of the function prototypes
> > from vsc-tp.h, so in this case I think we should go with my version.
>
> Oops, yep that makes sense to me.

Ok, I'll go take your series now, sorry for the delay.

greg k-h