Re: [PATCH] wifi: ath11k: fix suspend use-after-free after probe failure
From: Jeff Johnson
Date: Tue Jun 24 2025 - 11:37:29 EST
On 6/24/2025 1:32 AM, Johan Hovold wrote:
> On Tue, Jun 24, 2025 at 10:20:22AM +0200, Johan Hovold wrote:
>> Make sure to deregister the PM notifier to avoid a use-after-free on
>> suspend in case core initialisation fails (e.g. due to missing
>> firmware).
>
> Not sure it matters in this case, but forgot to include:
>
> Tested-on: WCN6855 hw2.0 WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.41
I'll add that.
I'll also change the Link: to Closes: per checkpatch:
WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
>
>> Fixes: 32d93b51bc7e ("wifi: ath11k: choose default PM policy for hibernation")
>> Reported-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>> Link: https://lore.kernel.org/all/d0cd065c-1cd1-4e56-8c57-60777b1f3664@xxxxxxxxxxxxxxxx/
>> Cc: Baochen Qiang <quic_bqiang@xxxxxxxxxxx>
>> Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
>
> Johan