Re: [PATCH net-next v5] docs: net: sysctl documentation cleanup

[Abdelrahman Fekry]

On Tue, Jun 24, 2025 at 3:54 PM Paolo Abeni <pabeni@xxxxxxxxxx> wrote:
>
> On 6/22/25 11:07 AM, Abdelrahman Fekry wrote:
> > @@ -593,10 +629,16 @@ tcp_min_rtt_wlen - INTEGER
> >       Default: 300
> >
> >  tcp_moderate_rcvbuf - BOOLEAN
> > -     If set, TCP performs receive buffer auto-tuning, attempting to
> > +     If enabled, TCP performs receive buffer auto-tuning, attempting to
> >       automatically size the buffer (no greater than tcp_rmem[2]) to
> > -     match the size required by the path for full throughput.  Enabled by
> > -     default.
> > +     match the size required by the path for full throughput.
> > +
> > +     Possible values:
> > +
> > +     - 0 (disabled)
> > +     - 1 (enabled)
> > +
> > +     Default: 0 (disabled)
>
> This uncorrectly changes the default value: should be 1.
>
> >  icmp_echo_ignore_broadcasts - BOOLEAN
> > -     If set non-zero, then the kernel will ignore all ICMP ECHO and
> > +     If enabled, then the kernel will ignore all ICMP ECHO and
> >       TIMESTAMP requests sent to it via broadcast/multicast.
> >
> > -     Default: 1
> > +     Possible values:
> > +
> > +     - 0 (disabled)
> > +     - 1 (enabled)
> > +
> > +     Default: 0 (disabled)
>
> Same here.
>
Thanks for feedback , will change it and look for other mistakes
> /P
>