Re: [PATCH] riscv: Enable interrupt during exception handling

From: Clément Léger
Date: Tue Jun 24 2025 - 07:37:38 EST




On 24/06/2025 04:09, Maciej W. Rozycki wrote:
> On Mon, 23 Jun 2025, Palmer Dabbelt wrote:
>
>> I'm kind of split on a Fixes tag here. One could argue it's a regression, as
>> having interrupts disabled during exceptions is going to cause all sorts of
>> performance issues for users. Seems a bit risk to just backport, though...
>>
>> That said, if nobody noticed then it's probably a good sign nobody is really
>> paying attention and we should just backport it before anyone notices...
>
> Oh, someone did notice and it's not only performance, cf.
> <https://lore.kernel.org/r/alpine.DEB.2.21.2501070143250.18889@xxxxxxxxxxxxxxxxx/>.

I also had a series which was doing so for misaligned accesses handling,
but after discussion, it was not ok to do so.:

https://lore.kernel.org/linux-riscv/20250422094419.GC14170@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/

So this series should probably be modified to only reenable interrupts
when explicitly needed, ie page faults and for force_sig_fault().

Thanks,

Clément

>
> Maciej
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-riscv