Re: [PATCH v2 3/5] serial: 8250: rename lsr_TEMT, iir_NOINT to lowercase

[Ilpo Järvinen]

On Tue, 24 Jun 2025, Jiri Slaby (SUSE) wrote:

> There are already variables like 'iir_noint1' and 'iir_noint2'. Follow
> the preexisting lowercase naming of variables. So s/lsr_TEMT/lsr_temt/
> and 'iir_NOINT' likewise.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx>
> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> ---
>  drivers/tty/serial/8250/8250_port.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
> index 5bb0ca04da55..7eddcab318b4 100644
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -2233,15 +2233,15 @@ static void serial8250_init_mctrl(struct uart_port *port)
>  static void serial8250_iir_txen_test(struct uart_port *port)
>  {
>  	struct uart_8250_port *up = up_to_u8250p(port);
> -	bool lsr_TEMT, iir_NOINT;
> +	bool lsr_temt, iir_noint;
>  
>  	if (port->quirks & UPQ_NO_TXEN_TEST)
>  		return;
>  
>  	/* Do a quick test to see if we receive an interrupt when we enable the TX irq. */
>  	serial_port_out(port, UART_IER, UART_IER_THRI);
> -	lsr_TEMT = serial_port_in(port, UART_LSR) & UART_LSR_TEMT;
> -	iir_NOINT = serial_port_in(port, UART_IIR) & UART_IIR_NO_INT;
> +	lsr_temt = serial_port_in(port, UART_LSR) & UART_LSR_TEMT;
> +	iir_noint = serial_port_in(port, UART_IIR) & UART_IIR_NO_INT;
>  	serial_port_out(port, UART_IER, 0);
>  
>  	/*
> @@ -2253,7 +2253,7 @@ static void serial8250_iir_txen_test(struct uart_port *port)
>  	 * variable. So, in case of UPQ_NO_TXEN_TEST, let's just don't test if we receive TX irq.
>  	 * This way, we'll never enable UART_BUG_TXEN.
>  	 */
> -	if (lsr_TEMT && iir_NOINT) {
> +	if (lsr_temt && iir_noint) {
>  		if (!(up->bugs & UART_BUG_TXEN)) {
>  			up->bugs |= UART_BUG_TXEN;
>  			dev_dbg(port->dev, "enabling bad tx status workarounds\n");
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

-- 
 i.