Re: [PATCH v1 1/1] i2c: acpi: Replace custom code with device_match_acpi_handle()
From: Andy Shevchenko
Date: Tue Jun 24 2025 - 07:14:26 EST
On Tue, Jun 24, 2025 at 12:18:22PM +0200, Rafael J. Wysocki wrote:
> On Tue, Jun 24, 2025 at 9:38 AM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Tue, Jun 24, 2025 at 10:25:59AM +0300, Mika Westerberg wrote:
> > > On Tue, Jun 24, 2025 at 10:19:02AM +0300, Andy Shevchenko wrote:
...
> > > But like I said, no objections. I just don't think this improves anything.
> >
> > I think there is an improvement.
>
> For example, this helps (I think) when someone uses something like LXR
> to look for places where a device is matched against a given ACPI
> handle, but only as long as device_match_acpi_handle() is used in all
> of those places consistently.
Yeah, this is a problem in the kernel that we may have a lot of legacy code
here and there. Unfortunately I have no plan to go all over, this is just
an ad-hoc change while debugging a regression (I hope not related to this
piece of code).
--
With Best Regards,
Andy Shevchenko