Re: [PATCH 2/2] lib/test_vmalloc.c: Restrict default test mask to avoid test warnings

[Baoquan He]

On 06/23/25 at 08:40pm, Uladzislau Rezki (Sony) wrote:
> When the vmalloc test is built into the kernel, it runs automatically
> during the boot. The current-default "run_test_mask" includes all test
> cases, including those which are designed to fail and which trigger
> kernel warnings.
> 
> These kernel splats can be misinterpreted as actual kernel bugs, leading
> to false alarms and unnecessary reports.
> 
> To address this, limit the default test mask to only the first few tests
> which are expected to pass cleanly. These tests are safe and should not
> generate any warnings unless there is a real bug.
> 
> Users who wish to explicitly run specific test cases have to pass the
> run_test_mask as a boot parameter or at module load time.
> 
> Cc: Harry Yoo <harry.yoo@xxxxxxxxxx>
> Cc: Suren Baghdasaryan <surenb@xxxxxxxxxx>
> Cc: David Wang <00107082@xxxxxxx>
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>
> ---
>  lib/test_vmalloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Baoquan He <bhe@xxxxxxxxxx>

> 
> diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c
> index 7264781750c96..c1966cf72ab89 100644
> --- a/lib/test_vmalloc.c
> +++ b/lib/test_vmalloc.c
> @@ -41,7 +41,7 @@ __param(int, nr_pages, 0,
>  __param(bool, use_huge, false,
>  	"Use vmalloc_huge in fix_size_alloc_test");
>  
> -__param(int, run_test_mask, INT_MAX,
> +__param(int, run_test_mask, 7,
>  	"Set tests specified in the mask.\n\n"
>  		"\t\tid: 1,    name: fix_size_alloc_test\n"
>  		"\t\tid: 2,    name: full_fit_alloc_test\n"
> -- 
> 2.39.5
>