Re: [PATCH] ALSA: qc_audio_offload: Fix missing error code in prepare_qmi_response()

From: Takashi Iwai
Date: Tue Jun 24 2025 - 04:11:37 EST


On Mon, 23 Jun 2025 16:26:27 +0200,
Harshit Mogalapalli wrote:
>
> When snd_soc_usb_find_priv_data() fails, return failure instead of
> success. While we are at it also use direct returns at first few error
> paths where there is no additional cleanup needed.
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Closes: https://lore.kernel.org/all/Z_40qL4JnyjR4j0O@stanley.mountain/
> Fixes: 326bbc348298 ("ALSA: usb-audio: qcom: Introduce QC USB SND offloading support")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>

Thanks, applied now.


Takashi