Re: [PATCH 2/2] dt-bindings: trivial-devices: Add mp2869a/mp29612a device entry

[Krzysztof Kozlowski]

On 24/06/2025 09:41, tzuhao.wtmh@xxxxxxxxx wrote:
> From: Henry Wu <Henry_Wu@xxxxxxxxxxxx>
> 
> Add trivial-devices binding for mp2869a/mp29612a to enable automatic matching
> in device tree.

Drop "enable automatic ...." - this is not what is being done here.
Instead describe the hardware.

Please organize the patch documenting compatible (DT bindings) before
their user.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46

> 
> Signed-off-by: Henry Wu <Henry_Wu@xxxxxxxxxxxx>


> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 27930708ccd5..e9a3a6f2c59e 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -287,8 +287,12 @@ properties:
>            - mps,mp2857
>              # Monolithic Power Systems Inc. multi-phase controller mp2888
>            - mps,mp2888
> +            # Monolithic Power Systems Inc. multi-phase controller mp2869a
> +          - mps,mp2869a

69 < 88


Best regards,
Krzysztof