Re: [PATCH v1 1/1] i2c: acpi: Replace custom code with device_match_acpi_handle()

[Mika Westerberg]

On Mon, Jun 23, 2025 at 04:45:21PM +0300, Andy Shevchenko wrote:
> Since driver core provides a generic device_match_acpi_handle()
> we may replace the custom code with it.

Well okay but now you replace a simple comparison with a function call. I'm
fine with the patch but I also don't think this is an improvement ;-)

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/i2c/i2c-core-acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c
> index d2499f302b50..3445cc3b476b 100644
> --- a/drivers/i2c/i2c-core-acpi.c
> +++ b/drivers/i2c/i2c-core-acpi.c
> @@ -250,7 +250,7 @@ static int i2c_acpi_get_info(struct acpi_device *adev,
>  
>  	if (adapter) {
>  		/* The adapter must match the one in I2cSerialBus() connector */
> -		if (ACPI_HANDLE(&adapter->dev) != lookup.adapter_handle)
> +		if (!device_match_acpi_handle(&adapter->dev, lookup.adapter_handle))
>  			return -ENODEV;
>  	} else {
>  		struct acpi_device *adapter_adev;
> -- 
> 2.47.2