Re: [PATCH v1 0/3] x86/boot: Supply boot_param in rdi instead of rsi from startup_64()

From: H. Peter Anvin
Date: Mon Jun 23 2025 - 20:50:30 EST


On June 23, 2025 11:39:09 AM PDT, Khalid Ali <khaliidcaliy@xxxxxxxxx> wrote:
>> This is also invoked by some external bootloaders that boot the ELF
>> image directly, even though this is strongly discouraged.
>>
>> Therefore this patchset is NAKed with extreme prejudice.
>
>Thanks both of you peter and brian,
>
>however, the boot protocol document saying "%rsi must hold the base address of the struct boot_params",
>it doesn't mention why. Maybe the document needs update to justify the reasons. I wouldn't have known it
>if you didn't tell me, so this shouldn't confuse anyone else.
>
>Thanks
>Khalid Ali

It is a *protocol*. An interface. "Because the interface specification says so" is really all the justification you need; otherwise you have to hunt down *every* user of the interface and verify your change.