Re: [PATCH v3 1/2] dt-bindings: media: i2c: Add bindings for AP1302 and AR0144

From: Laurent Pinchart
Date: Mon Jun 23 2025 - 18:41:48 EST

Hi Frank,

Thank you for the patch.

On Mon, Jun 23, 2025 at 03:17:37PM -0400, Frank Li wrote:
> From: Anil Kumar Mamidala <anil.mamidala@xxxxxxxxxx>
>
> The AP1302 is a standalone ISP for ON Semiconductor sensors, which can
> connect RAW sensors (AR0144).
>
> Add corresponding DT bindings.
>
> Signed-off-by: Anil Kumar Mamidala <anil.mamidala@xxxxxxxxxx>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Signed-off-by: Stefan Hladnik <stefan.hladnik@xxxxxxxxx>
> Signed-off-by: Florian Rebaudo <frebaudo@xxxxxxxxxxx>
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
> Previous try:
> https://lore.kernel.org/linux-media/1631091372-16191-2-git-send-email-anil.mamidala@xxxxxxxxxx/
>
> Change in v3:
> - Move sensors under ports
> - use compatible string to indentify connected raw sensors
> - Add onnn,ar0144.yaml
> ---
> .../devicetree/bindings/media/i2c/onnn,ap1302.yaml | 151 +++++++++++++++++++++
> .../devicetree/bindings/media/i2c/onnn,ar0144.yaml | 75 ++++++++++
> MAINTAINERS | 9 ++
> 3 files changed, 235 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,ap1302.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,ap1302.yaml
> new file mode 100644
> index 0000000000000..6b745dcf3fd3f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/onnn,ap1302.yaml
> @@ -0,0 +1,151 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/onnn,ap1302.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ON Semiconductor AP1302 Advanced Image Coprocessor
> +
> +maintainers:
> + - Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> + - Anil Kumar M <anil.mamidala@xxxxxxxxxx>
> +
> +description:
> + The AP1302 is a standalone ISP for ON Semiconductor sensors. It interfaces to
> + up to two RAW CMOS sensors over MIPI CSI-2 connections, processes the two
> + video streams and outputs YUV frames to the host over a MIPI CSI-2 interface.
> + Frames are output side by side or on two virtual channels.
> +
> + The sensors must be identical. They are connected to the AP1302 on dedicated
> + I2C buses, and are controlled by the AP1302 firmware. They are not accessible
> + from the host.
> +
> +properties:
> + compatible:
> + const: onnn,ap1302
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description:
> + Reference to the CLK clock.
> +
> + reset-gpios:
> + items:
> + - description:
> + Reference to the GPIO connected to the RST pin (active low).
> +
> + standby-gpios:
> + items:
> + - description:
> + Reference to the GPIO connected to the STANDBY pin (active high).
> +
> + enable-gpios:
> + items:
> + - description:
> + Reference to the GPIO connected to the EN pin (active high).
> +
> + dvdd-supply: true
> +
> + hmisc-supply: true
> +
> + smisc-supply: true
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> + unevaluatedProperties: false
> +
> + patternProperties:
> + "^port@[01]":
> + description:
> + Sensors connected to the first and second input, if no sensor
> + connect, isp generate test pattern. The compatible string under
> + port@0 and port@1 have to be the same.
> +
> + allOf:
> + - $ref: /schemas/graph.yaml#/$defs/port-base
> + - $ref: onnn,ar0144.yaml

You can't do that, that's plain wrong, sorry. There are issue raised in
the review of v2, please try to understand the problem and propose a
solution there. This is not what we need.

> +
> + unevaluatedProperties: false
> +
> + properties:
> + port@2:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> + properties:
> + clock-noncontinuous:
> + type: boolean
> +
> + data-lanes:
> + oneOf:
> + - items:
> + - const: 1
> + - items:
> + - const: 1
> + - const: 2
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> +
> + required:
> + - data-lanes
> +
> + required:
> + - port@2
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + camera@3c {
> + compatible = "onnn,ap1302";
> + reg = <0x3c>;
> +
> + clocks = <&clk24mhz>;
> +
> + reset-gpios = <&pio 102 GPIO_ACTIVE_LOW>;
> + standby-gpios = <&pio 40 GPIO_ACTIVE_HIGH>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + compatible = "onnn,ar0144";
> + reg = <0>;
> + vaa-supply = <&vaa_regulator>;
> + };
> +
> + port@2 {
> + reg = <2>;
> +
> + endpoint {
> + remote-endpoint = <&seninf_in1>;
> + clock-noncontinuous;
> + data-lanes = <1 2 3 4>;
> + };
> + };
> + };
> + };
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,ar0144.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,ar0144.yaml
> new file mode 100644
> index 0000000000000..68562cf4c00ca
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/onnn,ar0144.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/onnn,ar0144.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ON Semiconductor AP0144 RAW CMOS sensor

AP0144 seems to be a typo.

> +
> +maintainers:
> + - Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> + - Anil Kumar M <anil.mamidala@xxxxxxxxxx>

Listing people as maintainers when they had nothing to do with
development of a file isn't very polite.

> +
> +description:
> + AP0144 RAW CMOS can be use standalone with any SOCs, or work with AP1302
> + ISP.

How a sensor is used is not relevant for its DT bindings.

> +
> +properties:
> + compatible:
> + enum:
> + - onnn,ar0144
> + - onnn,ar0330
> + - onnn,ar1335

There's also no explanation for this.

> +
> + reg:
> + maxItems: 1
> +
> + vaa-supply: true
> +
> + vdd-supply: true
> +
> + vddio-supply: true
> +
> + vddpll-supply: true
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + additionalProperties: false
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + not:
> + contains:
> + const: onnn,ar0330
> + then:
> + properties:
> + vddpll-supply: false
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + camera@10 {
> + compatible = "onnn,ar0144";
> + reg = <0x10>;
> + vaa-supply = <&vaa>;
> + vddio-supply = <&vddio>;
> + vdd-supply = <&vdd>;

No input clock, reset signal, ports ?

> + };
> + };
> +
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d6f1670290589..1362d351f2574 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1766,6 +1766,15 @@ L: linux-sound@xxxxxxxxxxxxxxx
> S: Maintained
> F: sound/aoa/
>
> +AP1302 ON SEMICONDUCTOR ISP DRIVER
> +M: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> +R: Frank Li <Frank.Li@xxxxxxx>
> +L: linux-media@xxxxxxxxxxxxxxx
> +S: Maintained
> +T: git git://linuxtv.org/media.git
> +F: Documentation/devicetree/bindings/media/i2c/onnn,ap1302.yaml
> +F: Documentation/devicetree/bindings/media/i2c/onnn,ar0144.yaml
> +
> APEX EMBEDDED SYSTEMS STX104 IIO DRIVER
> M: William Breathitt Gray <wbg@xxxxxxxxxx>
> L: linux-iio@xxxxxxxxxxxxxxx

--
Regards,

Laurent Pinchart