Re: [PATCH RFC 14/29] mm/migrate: remove __ClearPageMovable()

[David Hildenbrand]

On 20.06.25 22:15, Zi Yan wrote:
> On 18 Jun 2025, at 13:39, David Hildenbrand wrote:
>
> > Unused, let's remove it.
> >
> > The Chinese docs in Documentation/translations/zh_CN/mm/page_migration.rst
> > still mention it, but that whole docs is destined to get outdated and
> > updated by somebody that actually speaks that language.
> >
> > Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
> > ---
> >   include/linux/migrate.h |  4 ----
> >   mm/compaction.c         | 11 -----------
> >   2 files changed, 15 deletions(-)
>
> The comment for struct movable_operations needs an update too.
> "
> If page migration is successful, the driver should call
> __ClearPageMovable(@src) and return MIGRATEPAGE_SUCCESS.
> "

Ah, thanks, it will simply be "should return MIGRATEPAGE_SUCCESS".

There is more magic to it (the driver must setup the dst page as
movable), but probably that might all be reworked soon.

--
Cheers,

David / dhildenb